Item six TX Fee Pallet
has a merge request here which needs a concept review.
paritytech:master
â dzmitry-lahoda-forks:dz/assets-tx-config
opened 10:46PM - 22 Aug 22 UTC
- [X] **Description:**
Allows user to configure default tx payment asset. S⌠ee https://github.com/paritytech/substrate/discussions/12055
- Is there something left for follow-up PRs?
Seems benchmarking can be improved, so not sure I have examples how to do multi assets in this repo (so it should be tested in cumulus).
cumulus companion:https://github.com/paritytech/cumulus/pull/1572
- [ ] **Labels:** You labeled the PR appropriately if you have permissions to do so:
- [ ] `A*` for PR status (**one required**)
- [ ] `B*` for changelog (**one required**)
- [ ] `C*` for release notes (**exactly one required**)
- [ ] `D*` for various implications/requirements
- [ ] Github project assignment
- [ ] **Related Issues:** Related https://github.com/ComposableFi/composable/pull/1456
- [ ] **2 Reviewers:** You asked at least two reviewers to review. If you aren't sure, start with GH suggestions.
- [x] **Style Guide:** Your PR adheres to [the style guide]
- [X] **Runtime Version:** You bumped the runtime version if there are breaking changes in the **runtime**. No breaking runtime, only compile time.
- [X] **Docs:** You updated any rustdocs which may need to change.
- [ ] **Polkadot Companion:** Has the PR altered the external API or interfaces used by Polkadot?
- [ ] If so, do you have the corresponding Polkadot PR ready?
- [ ] Optionally: Do you have a corresponding Cumulus PR?
1 Like
Great
Any plan on fixing the deposit issue with Pure proxy ? I would be happy to use this feature again, but the fact that it could lead to âinconsistent stateâ (where an account still has reserved tokens but no proxy anymore) is still a deal breaker for us.
(Refering to substrate/lib.rs at 101b8a05b232b3b5351e4d1cb85631a50960289d ¡ paritytech/substrate ¡ GitHub which associate the deposit to the âpure proxyâ and substrate/lib.rs at 101b8a05b232b3b5351e4d1cb85631a50960289d ¡ paritytech/substrate ¡ GitHub which tries to unreserve the âpure proxyâ (which does nothing because it doesnât have reserve but still removes the proxy)
(Yes you should use kill_pure
to remove a pure proxy, but the reality is that people will never do things the way they should )
steven
October 10, 2022, 12:45am
24
I think âvirtual accountâ more clear for normal people. the difference between âpure proxyâ and normal proxy account is the direction relation with origin account. this confused people a lot.
1 Like
dmoka
October 31, 2022, 6:59pm
25
The link to your integration tests seems to be broken. Could you please update it? Our team is checking this FUDGE lib right now and would be nice to see an example of how it is used. Thank you!
I can not anymore, but here is the updated version of the link.
https://github.com/centrifuge/centrifuge-chain/tree/main/runtime/integration-tests/src/pools
Feel free to ping me on element or so if you have questions. @mustermeiszer :matrix.org
1 Like