I finally spent some time reviewing your work.
-
Do you think if it is easy to add a new chain? e.g. chain def for Acala 4
There should be one chain that is using the most available features with comments on what is doing what. Otherwise looks okay. -
Do you think if it is easy to add new tests? e.g. tests between Acala and Moonbeam 1
Get rid off:
afterAll(async () => { await acalaClient.teardown() await moonbeamClient.teardown() await polkadotClient.teardown() })Also:
const restoreSnapshot = captureSnapshot(assetHubPolkadotClient, acalaClient, polkadotClient) beforeEach(restoreSnapshot)- Add an example showing how to send a custom XCM message that is using any prepared helper.
- Add some multi hop example
- Maybe one folder per test? Otherwise this one file maybe gets quite big over time
-
I designed a runner bot based on Github Action and Issues, take a look and see if it will work for you Command runner action · Issue #2 · open-web3-stack/polkadot-ecosystem-tests · GitHub 3
Looks good to me.Would be good to show how to run a test with a custom WASM binary
-
I plan to use Github notifications to deliver test failure notifications. Let me know what do you think. Notification System · Issue #5 · open-web3-stack/polkadot-ecosystem-tests · GitHub 1
Yes looks good to me.
Generally I think it is a good start and we can improve from there.